Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky cursor for step forward and step backward #532

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

rtetley
Copy link
Collaborator

@rtetley rtetley commented Aug 2, 2023

Closes #505.

- Added the sticky cursor option in the package.json file
- Tried using the updateHighlights notification to update the cursor to no avail
- TODO: Will need to create a custom notification type
In the language server:
- Added a MoveCursor notification type
- Added a function to get the last executed range in the DocumentManager
- Added all functions and processes to launch the notification on a stepForward or stepBackward
In the vscode extension:
- Added the mechanism to update the cursor on receiving a moveCursor notification.
@rtetley rtetley marked this pull request as ready for review August 2, 2023 09:52
Copy link
Member

@maximedenes maximedenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename and redocument last_executed_range as it is really the range of observe id. Also it would be better to make sure that we 1. jump the cursor, 2. execute and 3. display the proof context.

- Renamed the last_executed_range function to observe_id_range
- Created a new pre_execution priority
- Review priorities so that 1) we mve the cursor, 2) we execute, 3) we display the proof context
@maximedenes maximedenes merged commit 1437b6d into main Aug 3, 2023
@maximedenes maximedenes deleted the enhance/sticky-cursor branch August 3, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual mode sticky cursor
2 participants